search

hearmeneigh / fchat-rising

A heavily modded F-Chat 3.0 client for F-List
https://hearmeneigh.github.io/fchat-rising/
MIT License
39 stars 17 forks source link

Adds notifications when friend or bookmark logs in #388

Open FatCatClient opened 1 month ago

FatCatClient commented 1 month ago

Mentioned in #360, but it's its own issue. The fact I have to use a silent sound file to play quiet notifications is pretty dumb, but the whole notification and sound system is honestly kind of bonkers and could do with a refactor— but that's simply out of scope for this PR and would need some research regardless.

I intentionally neglected to add these notifications for friends signing off because I knew that it'd drive people up the wall if one of their friends has a spotty connection or is using mobile.

DemonPriestessSahala commented 1 month ago

It looks fine to me. Though, in light of the design decision, maybe change the option name "Notify when friends or bookmarks sign in and out"? Anyone who wants a different (non-silent) notification, like myself, can replace the silent sound file. Not a big deal.

Thank you!