search

hearobe / pe

0 stars 0 forks source link

Adding items with future purchase dates #5

Open hearobe opened 2 years ago

hearobe commented 2 years ago

To reproduce: Add a product with a date after the current date

Expected: An error stating that user should not be able to add an item that has not been purchased

Actual: Item is successfully added

Since this is an equipment manager to keep track of inventory, I would believe that only items that have already been purchased should be allowed to be added. Otherwise there could be a duplicate adding (if the user forgets and adds it again when it is purchased), or differences in the details that may be hard to keep track of (price could change when actually purchasing the product, and it may be hard for users to keep track of what needs to be edited). In the future I believe you wish to use the equipment manager for equipment bookings - having future purchases in the mix could make this very confusing, though not impossible!

image.png

image.png

I think this is part of the same issue, but it is possible to enter dates that do not really make sense (e.g. very far in the past). Perhaps there could be some limitations on a range of dates that could prevent any typos or other human error when typing dates.

image.png

nus-se-bot commented 2 years ago

Team's Response

Working as intended, sometimes we want to key in the record before the official purchase date. Besides, the duplicate adding mentioned should not be an issue because we already have measures to deal with duplicate serial numbers. This will not affect the operation of the application and causes little inconvenience to users, hence it should be Low severity.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I think that certain important purposes of an equipment manager would be

  1. to match the items currently in inventory with receipts to verify the purchase and reimburse the purchaser
  2. identify items which may be too old or outdated, for repairs or replacement I believe these can only be done if there is an accurate date entered, and thus the system could possibly improve its functionality by encouraging users to enter the accurate date by setting certain limits.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]