heartcombo / devise

Flexible authentication solution for Rails with Warden.
http://blog.plataformatec.com.br/tag/devise/
MIT License
23.89k stars 5.54k forks source link

require_no_authentication has an ambiguous name #5559

Open sitarane opened 1 year ago

sitarane commented 1 year ago

It might mean "you can be authenticated or not, we don't care". It could mean "being not authenticated is a requirement"

It turns out the be the latter.

There's a comment in above the method definition, but it's ambigous as well:

Helper for use in before_actions where no authentication is required.

A better comment could be:

Helper for use in before_actions where it is required to be unauthenticated

A better name for the method could be: