Closed marcoroth closed 1 year ago
What is devise's maintenance policy for maintained Rails versions? I'm wondering if we can remove Devise::DeprecatedConstantAccessor
and require Rails 5.1+ in 5.0, looking at the comment:
Copy of constant deprecation module from Rails / Active Support version 6, so we can use it with Rails <= 5.0 versions. This can be removed once we support only Rails 5.1 or greater.`
This should be fixed on master now
Any ETA when this'll get released? It's quite noisy in Rails 7.1 😅
@rafaelfranca What's stopping a new release (that will then include this fix)? Like miharekar said: It's noisy in Rails 7.1.
For those wondering, Devise 4.9.3 was released with the fix for this back in October 2023: https://rubygems.org/gems/devise/versions/4.9.3 https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#493---2023-10-11
Environment
2f08f9a
Current behavior
Context: https://github.com/rails/rails/pull/47354
Expected behavior
The gem shouldn't log a deprecation warning