search

heartcombo / devise

Flexible authentication solution for Rails with Warden.
http://blog.plataformatec.com.br/tag/devise/
MIT License
23.95k stars 5.55k forks source link

I18n is incomplete #5619

Closed jpgeek closed 1 year ago

jpgeek commented 1 year ago

Environment

Current behavior

Many of the templates are not I18n enabled. For example in devise/registrations/edit.html.erb The line: <h2>Edit <%= resource_name.to_s.humanize %></h2>

does not translate the term "Edit".

Expected behavior

All text should be translated. The above line would be something like: <h2>I18n.t('devise.registrations.edit') <%= resource_name.to_s.humanize %></h2>

carlosantoniodasilva commented 1 year ago

We've historically decided against translated the views, so we don't have any I18n in there. It's easy to copy the views over or use one of the 3rd-party gems that provide this functionality. (this is something I've considered to change more recently and introduce i18n, but I'm not ready to make that commitment, so for now the decision is still the same, no i18n in the views.)

jpgeek commented 1 year ago

Understood. Will skip the PR then. Appreciate the quick response and your work on Devise.