search

heartcombo / devise

Flexible authentication solution for Rails with Warden.
http://blog.plataformatec.com.br/tag/devise/
MIT License
23.83k stars 5.53k forks source link

`confirmation_sent_at` is set regardless `skip_confirmation_notification!` method call #5659

Open bogdanvlviv opened 7 months ago

bogdanvlviv commented 7 months ago

Related to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138501#note_1686234692

User's confirmation_sent_at is set regardless skip_confirmation_notification! when creating new user.

bogdanvlviv commented 7 months ago

I found the reason why confirmation_sent_at is always set https://github.com/heartcombo/devise/issues/4536#issuecomment-312870410. I think we should add a new column to track when confirmation token was generated instead of using confirmation_sent_at.