search

heartcombo / devise

Flexible authentication solution for Rails with Warden.
http://blog.plataformatec.com.br/tag/devise/
MIT License
23.83k stars 5.53k forks source link

Example for 7.1.0 is effectively useless #5684

Closed AlvesJorge closed 2 months ago

AlvesJorge commented 2 months ago

First of all thank you for your work on this gem!

I have an issue with the devise example for Rails 7.1.0, you will find it has:

There is no actual example on how the Gem is used at all within a basic application, instead it is only showing us what it looks like to have the gem installed.

This is effectively useless, and will waste the time of everyone who opens this example.

carlosantoniodasilva commented 2 months ago

Thanks, that example is not something Devise / heartcombo is related with in any way, so if you feel like their Readme doesn't show enough steps to help someone get started, feel free to open an issue there.

If you feel like you can improve Devise's readme, PRs are welcome.

AlvesJorge commented 2 months ago

Hi @carlosantoniodasilva The example is linked in the heartcombo/devise wiki, so it is related. https://github.com/heartcombo/devise/wiki/Example-Applications

carlosantoniodasilva commented 2 months ago

@AlvesJorge ah I see... well, the wiki is also community maintained, we don't lock it to keep updates only to ourselves, everyone can do it, so the best I can do is to remove that (or you could remove it yourself too...)

It does warrant some reviewing in those wiki pages at some point, I'll keep note on that but can't promise if / when that would happen.

AlvesJorge commented 2 months ago

No need to promise, I just wanted to point that out. All the best!