search

heartcombo / devise

Flexible authentication solution for Rails with Warden.
http://blog.plataformatec.com.br/tag/devise/
MIT License
24.01k stars 5.55k forks source link

Fix: email format #5714

Open abdulaba opened 2 months ago

abdulaba commented 2 months ago

Problem: You can register an invalid email: john.doe@gmail Fix: Regular expresion

devise.rb

@@email_regexp = /\A[^@\s]+@[^@\s]+.[^@\s]+\z/

rafaeldev commented 2 months ago

Hi @abdulaba !

I figured out this point and I fixed it in devise.rb config file with: config.email_regexp = /\A[\w+\-.]+@[a-z\d\-]+(\.[a-z]+)*\.[a-z]+\z/i

I don't remember where I saw it, but that default simple validation is for solving some local case emails

abdulaba commented 2 months ago

Great! Thanks for answering.

Best regards

Andrés Ibáñez Ulloa

El El lun, 23 de sep. de 2024 a la(s) 00:01, Rafael Gomes < @.***> escribió:

Hi @abdulaba https://github.com/abdulaba !

I figured out this point and I fixed it in devise.rb config file with: config.email_regexp = @.**\d-]+(.[a-z]+).[a-z]+\z/i

I don't remember where I saw it, but that default simple validation is for solving some local case emails

— Reply to this email directly, view it on GitHub https://github.com/heartcombo/devise/pull/5714#issuecomment-2367152216, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJSPLD7SUT3GE3ALDJFNYLZX6ABXAVCNFSM6AAAAABOJZW6LCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGE2TEMRRGY . You are receiving this because you were mentioned.Message ID: @.***>