Potential Update for Rails7 with Ruby3.1

[mikeh-dev]

https://github.com/heartcombo/devise/blob/12c796e4994c9fbdc12eb0d6b70450cf82fcec62/test/rails_app/config/initializers/devise.rb#L102

Environment

• Ruby 3.1.2
• Rails 7.0.7
• Devise 4.9.4

Current behaviour

I ran into a failing test with Rspec on the valid email check

The original regex here;

config.email_regexp =/^([\w.%+-]+)@([\w-]+.)+([\w]{2,})$/i

was failing on a new line error

Solution

I corrected to

/\A([\w.%+-]+)@([\w-]+.)+([\w]{2,})\z/i

Basically the same but changing the start and end removed the multiline anchors error for me. OLD uses ^ and $: Matches start/end of any line NEW uses \A and \z: Matches start/end of entire string

Not sure if this is correct as this is my first contribution but I came across and thought I would drop it in.

Cheers

[JalisoCSP]

Seems legit to me

You should make a PR :) 👏

[mikeh-dev]

Seems legit to me

You should make a PR :) 👏

Cheers! I'll get onto it