search

heartcombo / responders

A set of Rails responders to dry up your application
http://blog.plataformatec.com.br/
MIT License
2.05k stars 156 forks source link

Require at least ruby 2.0.0 #207

Closed deivid-rodriguez closed 5 years ago

deivid-rodriguez commented 5 years ago

Thoughts about dropping ruby 1.9.3 support? It's very old...

deivid-rodriguez commented 5 years ago

Motivation is that 1.9.3 no longer seem to install on TravisCI: https://travis-ci.org/plataformatec/responders/jobs/548146918.

sourcelevel-bot[bot] commented 5 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/plataformatec/responders/pulls/207.

deivid-rodriguez commented 5 years ago

Sorry, I was just experimenting with getting CI green, didn't intend to get this merged. My bad, I'll make sure I make this kind of experiments on a separate branch without an associated PR in the future, so you don't review code unnecessarily.