search

heartcombo / responders

A set of Rails responders to dry up your application
http://blog.plataformatec.com.br/
MIT License
2.05k stars 156 forks source link

Import ActionController::MissingRenderer from Rails #245

Open zzak opened 1 year ago

zzak commented 1 year ago

Happened upon this exception when patching this file in rails/rails#48327, the documentation references a method which was moved to this gem, and nothing else in Rails uses it internally.

I think we can move it here and deprecate it from Rails, which I've started working on in rails/rails#48328

carlosantoniodasilva commented 6 months ago

@zzak I can get this into responders and released, but we'll have to update the Rails side of things a bit apparently... we might also have to detect here if the constant is not already defined or something (suppressing possible warnings), I think?

zzak commented 6 months ago

@carlosantoniodasilva Thanks for the ping, yeah I'm not sure but maybe we can do unless defined??

I have to fix the tests (and probably rebase) upstream too, but I think the right thing to do is do the check on responders side.