search

heartcombo / simple_form

Forms made easy for Rails! It's tied to a simple DSL, with no opinion on markup.
http://blog.plataformatec.com.br/tag/simple_form
MIT License
8.22k stars 1.32k forks source link

Make error_class work on inner wrapper #1729

Open lafeber opened 3 years ago

lafeber commented 3 years ago

Fix for https://github.com/heartcombo/simple_form/issues/1727

lafeber commented 3 years ago

@carlosantoniodasilva If you have some time to look at this, it would be greatly appreciated!

lafeber commented 3 years ago

@rafaelfranca If you have some time to look at this, it would be greatly appreciated!

carlosantoniodasilva commented 3 years ago

@lafeber I did get your initial ping and should've commented back that'd get to it here, that was my bad, but please be a little patient. :) Thanks!

lafeber commented 3 years ago

@carlosantoniodasilva I'm truly sorry, I didn't mean to be impatient. I appreciate all the work you put in this gem - it's one of my all time favourites.

jeremybdk commented 3 years ago

Hello everyone, I was wondering if you plan to merge this as we're also facing this issue.

Thanks

HectorMF commented 2 years ago

This change solves some issues I was having as well, would be great if it was merged in!

nashby commented 2 years ago

@rafaelfranca @lafeber I updated this PR with a fix to how we check for input's errors. Previously it wasn't properly checking it so my newly added spec was failing. I fixed that. @rafaelfranca @carlosantoniodasilva if PR looks good to you I'll merge it and will update Changelog/README afterward.