Closed mhw closed 2 years ago
👀 https://github.com/heartcombo/simple_form/pull/1729 maybe could become interesting with the issue around .has-validation
for input groups
Thank you for this PR !
When do you think this branch will be merged?
So this gem doesn't use Bootstrap 5 by default? How do I use Bootstrap 5 with this gem?
@o-t-w we don't have this in the main repo yet, which is my fault for not having finished reviewing the change... I'll get to this soon.
Anyway, all you need is the initializer that comes with this PR, you should be able to copy it from the app where it's kept current: https://github.com/heartcombo/simple_form-bootstrap/blob/master/config/initializers/simple_form_bootstrap.rb (we just bundle the initializer with SF to make it simpler to install upfront)
Nice to find this issue... I was really wondering what was wrong with my configuration, since the design was broken with Bootstrap 5 in a new app.
It seems that copying the new initializer solves most issues, Thanks!!
The only strange thing is that the btn
is completely white (and it doesn't look like a button), maybe it should be set to btn-primary
by default?
I've just come across this issue when generating a new Rails application that uses Bootstrap 5 and realising that Simple Form doesn't have Bootstrap 5 support yet.
@carlosantoniodasilva - I don't suppose you know when this might be merged in and released? :crossed_fingers:
@mhw thank you!
This syncs up the generator template with the new one from
simple_form-bootstrap
.There's a minor issue with the styling of validation errors in input groups that I'd like to look at, but I don't think we need to wait for that before merging this in.
/cc @m5o