Missing form-select on bootstrap simple forms

alex-benoit commented 2 years ago

Environment

Ruby 3.0.2
Rails 6.1.4.1
Simple Form 5.1.0

Current behavior

For bootstrap,

<%= f.input :channel, collection: @stuff %>

generates a select but just add the form-control class

Expected behavior

The bootstrap form-select class should be added

gdonald commented 2 years ago

I ran into this also. Not sure how to "fix it" as adding a customization in simple_form_bootstrap.rb like b.use :select, class: 'form-select' breaks all my instances of f.input ....

nashby commented 2 years ago

It works now.

alessandro-fazzi commented 2 years ago

@nashby as far as I can see, it works now on main, but not in 5.1.0 (latest) release.

5.1.0 was released on 9 Feb 21
87c60c56bd122775d85412b29cee7c837941f8b5 shipped on 28 May 21

I've just made a poor man test:

had the problem
updated my Gemfile with gem 'simple_form', github: 'heartcombo/simple_form', branch: 'main'
bin/rails g simple_form:install --bootstrap overwriting previous config
now it works

I don't know if project's policy is to consider an issues to be resolved when the fix hits main and don't know if you'd like to have a new issue filled or, finally, if I'm wrong :)

f16z commented 2 years ago

I spent too much time trying to fix this, hopefully gets put into a stable release soon.

thanks.

heartcombo / simple_form