search

heartcombo / simple_form

Forms made easy for Rails! It's tied to a simple DSL, with no opinion on markup.
http://blog.plataformatec.com.br/tag/simple_form
MIT License
8.21k stars 1.31k forks source link

Test suite incompatibility with Rails 7.1.0.alpha - Failing CI #1801

Closed petergoldstein closed 1 year ago

petergoldstein commented 1 year ago

Environment

Current behavior

The CI suite fails on the 'custom wrappers on input basis' test in test/form_builder/wrapper_test.rb. This test calls replace on the output_buffer object, which is of type ActionView::OutputBuffer.

In Rails 7.1.0.alpha the ActionView::OutputBuffer class was changed such that it is no longer a subclass of String, and now this method is unavailable.

Expected behavior

Test suite should pass and Simple Form should be compatible with Rails 7.1 in tests.

nashby commented 1 year ago

@petergoldstein thanks for reporting it! It was fix as part of https://github.com/heartcombo/simple_form/pull/1782