heartpoints / heartpoints.org

3 stars 4 forks source link

Code coverage #180

Closed tommysullivan closed 5 years ago

tommysullivan commented 5 years ago

@bob-bins looks like i can run and get coverage report locally, including if i add reporter "html" in the "nyc" block of package.json

it looks like the pull request job is trying to update codecov.io with the report, but does not find a report; probably because the report gets generated within the running docker container during the docker build.

so i was thinking of mounting the coverage folder in the calling environment so that this step could see the coverage file. hopefully if it does then our viewer here at https://codecov.io/gh/heartpoints/heartpoints.org will actually show something.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (restguru@3dbfa0f). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             restguru     #180   +/-   ##
===========================================
  Coverage            ?   29.71%           
===========================================
  Files               ?      234           
  Lines               ?     1400           
  Branches            ?       81           
===========================================
  Hits                ?      416           
  Misses              ?      984           
  Partials            ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3dbfa0f...5a7d72a. Read the comment docs.