heartsentwined / ember-auth-rails-demo

rails + devise + ember-auth demo site
121 stars 16 forks source link

Best place to use RememberMe.recall() #2

Closed AshesOfOwls closed 11 years ago

AshesOfOwls commented 11 years ago

Don't have a bug, just a question for you. I was wondering why you decided to put the Auth.Module.RememberMe.recall() within the didInsertElement function of the application view and not within the init function of the application route. I tried it and it seems to be working fine all the while triggering it slightly sooner. Is there a caveat to doing this that I am missing?

heartsentwined commented 11 years ago

My apologies for the delay.

I have released a new version of ember-auth. This new version will call Auth.Module.RememberMe.recall() automatically by default, eliminating the need for userland code on this method. You can read more about this feature in the readme, and in this issue.

AshesOfOwls commented 11 years ago

Excellent! Thanks!