Refreshing the users list shows in no results

heartsentwined / ember-auth-rails-demo

rails + devise + ember-auth demo site

121 stars 16 forks source link

Refreshing the users list shows in no results #6

Closed drewcovi closed 11 years ago

drewcovi commented 11 years ago

After logging in, and refreshing the users list, for some reason the results come up blank. toggling back and forth between the posts and users brings the list back.

heartsentwined commented 11 years ago

A known issue, hang on until I got a fix.

drewcovi commented 11 years ago

no worries at all, your demo and docs set the bar :)

heartsentwined commented 11 years ago

Related to #3 - ref. this write of mine.

heartsentwined commented 11 years ago

Update: ember has got a new router, which is heavily relevant to authenticated-backed apps. I'm working with it to update ember-auth with the new APIs. For now, this issue is put on hold - I'll reproduce the scenario after I finish with the new router, and see if the issue persists.

Ref:

drewcovi commented 11 years ago

Hey! Yeah I updated a few nights ago and were in business! There may be some cruft now, but loving the progress so far!

heartsentwined commented 11 years ago

Issue fixed with ember rc6 and ember-auth 7.x adoption. The tutorial (in wiki) is updated with new instructions.

7.x branch now released, with rc6 (new router!) support. changelog, upgrade guide, docs and demo all properly updated. Main notes:

ember-auth now requires ember rc6 or above
the new router now encourages you to use authRedirectable as "the ember way" of solving auth-only routes (with auth-only models)
thus you might want to pair it with actionRedirectable too for user experience
despite this being a major version update, it would likely not break most userland code; the BC breaks are not in main, documented API

raphaelsaunier commented 11 years ago

Nice work on the 7.x update and thanks for the upgrade guide!

I'm now running into a slightly different issue with your demo on Heroku; the parameter for the users route transitions to undefined when you visit the page directly or when you refresh it. This is also happening with the posts route, but only when you're logged in.

e.g.: /posts/1-post-1 will turn into /posts/undefined

heartsentwined commented 11 years ago

confirmed; will work on it.

heartsentwined commented 11 years ago

I cannot figure it out at ember-auth - as far as I know, it adheres to the router facelift guide fully. I have reported this issue upwards at emberjs/ember.js#2946.

heartsentwined commented 11 years ago

@raphaelsaunier confirmed to be an ember issue - refer to emberjs/ember.js#2946. They have fixed this already, but the fix is not included in rc6; it's in master.