search

heathdutton / mautic

Mautic: Open Source Marketing Automation Software.
https://www.mautic.org
Other
0 stars 1 forks source link

php73 #6

Open calevans opened 5 years ago

calevans commented 5 years ago

Please DO NOT report security vulnerabilities here. Send them to security@mautic.com instead.

What type of report is this:

Q A
Bug report? Y
Feature request?
Enhancement?

Description:

I know they closed your PR but the patch was still useful. Unfortunately, they have changed the file since then. I'm no expert on diff and patch. I managed to get this working manually:

https://gist.githubusercontent.com/calevans/d3f582ae5b91daebe4ed0a211ca30782/raw/97d6aabd399d8803efb8430d1d99408cec78c857/doctrine.patch

but can't get it quite right for composer to apply it automatically. Hoping you might be able to help. :)

Cheers! =C=

heathdutton commented 5 years ago

I'm not sure why we'd need to change that patch unless mautic core changed which version of the symfony package they use. That doesn't appear to be the case.

Regardless, I've merged conflicts and we'll let Travis re-test and see.

heathdutton commented 5 years ago

Mautic core did not change the orm version, so the existing patch is fine. Proof: https://travis-ci.org/mautic/mautic/builds/528863822 Note, that patch won't work if you do something like composer update and thereby change what version of the orm package you are personally using. That is not recommended, as that means you end up on a bunch of package versions that nobody else is testing/using. Risky business.