Open heathersummers opened 6 years ago
Hi @heathersummers ,
Readme file is clean and informative, contains all the related link and your app features.
Compared what we have done in course, you add the download button to help user get the results, the data source link, and give more multiple choices for alcohols type. Just one thing, as to country choices, maybe it would be better to give a choice to user about whether or not they want to filter by country, cause sometimes people may want the whole results instead of just one country.
I especially love the histogram part, you labeled everything clearly and the theme you chose looks great. I should apply this into my code đź‘Ť
Picked 8 features instead of 3 and finish each one perfectly.
Overall a very solid work and you understand the mechanics behind shinny app, which is important.
Best, Ziming
Dear @heathersummers,
Sorry for the late review, I have been sick with a cold recently and somehow, that one slipped through. Here is a funny one: I also performed the wrong peer review. Oh well, my mom used to say all the time: Mieux vaut en rire qu'en pleurer (which means, better to laugh about it than cry about it, and that's the way I will go with it ;) !
Excellent work, your app fulfill all the requirements:
ui.R
and a server.R
You also explored a multitude of additional features:
shinytheme("readable")
to alter the appearance of the App, which makes it visually pleasing. img(src = "BCliquor_logo.jpg", width="450x")
to include an image.DT::dataTableOutput()
to render a searchable table.reactive({})
to filter data according to user input. checkboxGroupInput()
for selection of Product type(s): Thank you for showing me how to use this option !downloadButton()
to make data table available to user ! I love that you put a line "Created by Heather Summers, with code adapted from Dean Attali" in your Shiny App ! I also think it's great that you included references for where you learned how to write some tricky parts of the code.
I really like the addition of colours for each alcohol type as well :)
Error: An error has occurred. Check your logs or contact the app author for clarification.
I played a little with your app and I suggest the simple little following tweak in your server.R
file (line 36) to resolve this issue: change Type == input$typeInput
to Type %in% input$typeInput
. That way, if the user does not select any option, it doesn't return an error message.
if (is.null(input$countryInput)) {
return(NULL)
}
Warm regards, My Linh
App uses ui.R and server.R file: Yes Deployed online: Yes Course repo includes README, code: Yes Acknowledge datset source: Yes New app or 3+ added features: Yes (7 features) Reflection: Yes
Comments:
Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.
Please see my Shiny app. Feel free to select different product types, price ranges, and countries and see what options are available for you.
My hw08 folder contains the code for my Shiny app as well as a description of features I added and a reflection.