heathfrankel / inferno-au-core

Use this template to start making your own Inferno Test Kit
Apache License 2.0
1 stars 1 forks source link

Prepare the demo data to pass all tests. #13

Open projkov opened 8 months ago

projkov commented 8 months ago

According to the state of the test groups, looks like we should prepare the demo data for the tests.

Conditions:

  1. Start point is the default example resources from the package;
  2. All resources should be available as clean JSON resources;
  3. All changes should be produced step by step for providing details via git diff.
projkov commented 8 months ago

There is a table displaying each test along with its related details, providing a clear overview of the progress. https://docs.google.com/spreadsheets/d/1DSIIi-V2IRSJzUUuhggO9RGxK2llHFl3/edit?usp=sharing&ouid=114127786440816887867&rtpof=true&sd=true

Summary

In general, we have identified several common issues:

  1. Tests attempting to retrieve attributes that should not be present in the profile (8 test groups).
  2. Tests encountering a situation where resources and patient references exist, but the search result is empty (7 test groups).
  3. Tests facing a scenario where resources exist but lack a reference to the patient, resulting in an empty search result (3 test groups).
  4. A single test exhibiting a problem within the source code of the generator (1 test group).
  5. Test groups that should not be present (3 test groups).
projkov commented 8 months ago

There is a table displaying each test along with its related details, providing a clear overview of the progress. https://docs.google.com/spreadsheets/d/1DSIIi-V2IRSJzUUuhggO9RGxK2llHFl3/edit?usp=sharing&ouid=114127786440816887867&rtpof=true&sd=true

Summary

In general, we have identified several common issues:

  1. Tests attempting to retrieve attributes that should not be present in the profile (8 test groups).
  2. Tests encountering a situation where resources and patient references exist, but the search result is empty (7 test groups).
  3. Tests facing a scenario where resources exist but lack a reference to the patient, resulting in an empty search result (3 test groups).
  4. A single test exhibiting a problem within the source code of the generator (1 test group).
  5. Test groups that should not be present (3 test groups).

Tests attempting to retrieve attributes that should not be present in the profile This problem was fixed

projkov commented 8 months ago

Problem with patternCoding values was fixed

projkov commented 8 months ago

@ir4y

I found a problem related to empty responses for some test groups, ex: 1.8 Observation Pathology Result Tests, 1.16 Observation Diagnostic Imaging Result Tests.

The problem is hidden in the generator implementation. The first search is always should have default values because it is the request to the server to get the data. In these examples, the first test is a test related to the code. code is not fixed in these examples.

I will find a way to fix it soon.

projkov commented 8 months ago

@ir4y

I found a problem related to empty responses for some test groups, ex: 1.8 Observation Pathology Result Tests, 1.16 Observation Diagnostic Imaging Result Tests.

The problem is hidden in the generator implementation. The first search is always should have default values because it is the request to the server to get the data. In these examples, the first test is a test related to the code. code is not fixed in these examples.

I will find a way to fix it soon.

The problem was related to the position of the search parameter in the list of all search parameters. Now it is fixed.

The table of the problems has an actual state.

projkov commented 7 months ago

I made a few updates related to the observation profile tests. The table with information was updated.