Closed paul-sud closed 4 years ago
I should add, this is using the most current gemBS revision.
Hi Paul,
Thanks for the report - clearly a bug. Is this from the master or devel branch?
Cheers, Simon
On Mon, Jan 27, 2020 at 5:33 PM Paul Sud notifications@github.com wrote:
Reopened #69 https://github.com/heathsc/gemBS/issues/69.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/heathsc/gemBS/issues/69?email_source=notifications&email_token=AAY4652I3CIEI4ID7KVMCN3Q74EGHA5CNFSM4KMEGMNKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWHCYTVA#event-2982513108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY4655HKDN27PQ2FK2BGYDQ74EGHANCNFSM4KMEGMNA .
Thanks for the quick response Simon. This is on master
OK, in the file gemBS/tools/gemBS_plugins/output.c, line 133 is currently:
fprintf(fp,"%s\t%" PRId64 "\t%" PRId64 " \t%c", args->hdr->id [BCF_DT_CTG][rec->rid].key, rec->pos + pos, rec->pos + pos + 1, cx_len >= 3
pos ? cx[2 + pos] : '.');
and should be changed to:
fprintf(fp,"%s\t%" PRId64 "\t%" PRId64 "\t%c", args->hdr->id [BCF_DT_CTG][rec->rid].key, rec->pos + pos, rec->pos + pos + 1, cx_len >= 3
If this solves your issue then I will push the fix to master.
Thanks again for the report. Simon
On Mon, Jan 27, 2020 at 5:42 PM Paul Sud notifications@github.com wrote:
Thanks for the quick response Simon. This is on master
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/heathsc/gemBS/issues/69?email_source=notifications&email_token=AAY46557C34P3VJVOOPOYQ3Q74FGNA5CNFSM4KMEGMNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKAFY4A#issuecomment-578837616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY46522G23JAPQW5OTOQW3Q74FGNANCNFSM4KMEGMNA .
I have just pushed the fix to master (and devel as the same fault was there as well)
On Mon, Jan 27, 2020 at 5:55 PM Simon Heath simon.heath@gmail.com wrote:
OK, in the file gemBS/tools/gemBS_plugins/output.c, line 133 is currently:
fprintf(fp,"%s\t%" PRId64 "\t%" PRId64 " \t%c", args->hdr->id [BCF_DT_CTG][rec->rid].key, rec->pos + pos, rec->pos + pos + 1, cx_len >= 3 + pos ? cx[2 + pos] : '.');
and should be changed to:
fprintf(fp,"%s\t%" PRId64 "\t%" PRId64 "\t%c", args->hdr->id [BCF_DT_CTG][rec->rid].key, rec->pos + pos, rec->pos + pos + 1, cx_len >= 3 + pos ? cx[2 + pos] : '.');
If this solves your issue then I will push the fix to master.
Thanks again for the report. Simon
On Mon, Jan 27, 2020 at 5:42 PM Paul Sud notifications@github.com wrote:
Thanks for the quick response Simon. This is on master
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/heathsc/gemBS/issues/69?email_source=notifications&email_token=AAY46557C34P3VJVOOPOYQ3Q74FGNA5CNFSM4KMEGMNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKAFY4A#issuecomment-578837616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY46522G23JAPQW5OTOQW3Q74FGNANCNFSM4KMEGMNA .
Thanks Simon, the fix on master worked.
In recent updates to the code it looks like the gemBS style bed files have an extra space inserted as a delimiter after the third column after the feature end coordinate, in addition to the usual tab. Oddly, this doesn't seem to occur with the ENCODE-style bed files. tabix also seemed to run successfully on the file too. The data here was produced by running a subset of the test set from here: http://statgen.cnag.cat/GEMBS/UserGuide/_build/html/example.html
ENCODE-style bed files:
gemBS-style bed file, note the
#
after the feature stop coordinate:I have some downstream processing that relies on the bed files being well-formed, and would appreciate a solution.
Thanks,
Paul