heathsc / gemBS

gemBS is a bioinformatics pipeline designed for high throughput analysis of DNA methylation from Whole Genome Bisulfite Sequencing data (WGBS).
GNU General Public License v3.0
32 stars 21 forks source link

R1 and R2 specific left and right trim values #77

Closed will-NYGC closed 3 years ago

will-NYGC commented 3 years ago

Is there a way to apply different (left|right)_trim values to R1 and R2?

heathsc commented 3 years ago

Not at the moment although this could be added without too much difficulty. For my curiosity, could you give a brief description of a situation where this would be useful?

Cheers, Simon

On Fri, Oct 2, 2020 at 1:10 PM will-NYGC notifications@github.com wrote:

Is there a way to apply different (left|right)_trim values to R1 and R2?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/heathsc/gemBS/issues/77, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY4652EUEMPP2SR6GZSVMLSIWYKLANCNFSM4SBSCPWQ .

will-NYGC commented 3 years ago

We are using the Swift Accel-NGS MethylSeq kit on cfDNA (short frags) which appends a synthetic oligo to the 3' end of ssDNA in order to ligate adapters (https://swiftbiosci.com/wp-content/uploads/2019/02/16-0853-Tail-Trim-Final-442019.pdf). This synthetic oligo appears at the end of R1 and beginnig of R2. Rather than hardclipping the reads, we thought we could avoid defects in methylation calling caused by this by using gemBS trim values. Currently we use bwameth+MethylDackel where this is possible but we like your full gemBS pipeline and would like to switch over.

heathsc commented 3 years ago

OK, let me think about the best way to implement this.

Simon

On Tue, Oct 6, 2020 at 4:13 PM will-NYGC notifications@github.com wrote:

We are using the Swift Accel-NGS MethylSeq kit on cfDNA (short frags) which appends a synthetic oligo to the 3' end of ssDNA in order to ligate adapters ( https://swiftbiosci.com/wp-content/uploads/2019/02/16-0853-Tail-Trim-Final-442019.pdf). This synthetic oligo appears at the end of R1 and beginnig of R2. Rather than hardclipping the reads, we thought we could avoid defects in methylation calling caused by this by using gemBS trim values. Currently we use bwameth+MethylDackel where this is possible but we like your full gemBS pipeline and would like to switch over.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/heathsc/gemBS/issues/77#issuecomment-704297193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY4653PZ4NGFW7O74KG5ULSJMQXLANCNFSM4SBSCPWQ .

heathsc commented 3 years ago

This has now been added in 3.5.3. From gemBS or bs_call, left_trim and right_trim options can now take either 1 or 2 values. If 2 values are specified then this give the trim values for read 1 and read 2 respectively. If only 1 value is specified then both reads are trimmed using the same value for the trim parameter (i.e., the previous behaviour)