search

heatseeknyc / landlord-lookup-client

A simple web frontend for the Landlord Lookup portal
Other
1 stars 0 forks source link

"internal error" on 22 Wall St #13

Closed wstlabs closed 7 years ago

wstlabs commented 7 years ago

the "internal error" response to a search query -- which indicates that there was some kind of exception caught, server side -- by definition indicates that some (avoidable) processing condition hasn't been properly checked, server side (regardless of what the user types).

Most recently it has occurred in the case of 22 Wall Street (see image). We should see what's up with that + fix if possible.

internal-error-22-wall-street

Other addresses where this happens:

Note that that both of these are invalid addresses (there's no lot corresponding to those house numbers).

Resolution The immediate cause of these exception is an attempt to cast None (for bin,bbl) to ints. The reason those values come ups is that the Geoclient API attempt to be helpful to interpolate the lat/lon (and it seems provide guesstimates for nearby house numbers). Really we should be catching those situations and returning a simple "invalid address" response.

wstlabs commented 7 years ago

Currently seeing the following exception trace in association with these fails:

DEBUG - 2017-03-13 17:37:41,504 :: wrapsafe :: exception = int() argument must be a string, a bytes-like object or a number, not 'NoneType'
wstlabs commented 7 years ago

Closing in that the issue is partially resolved (for 22 Wall St) while the other issues have been found to have a more specific cause. See issue/19 and issue/20.