search

heatsynclabs / new-hsl

HeatSync Labs website
heatsynclabs.org
20 stars 25 forks source link

Migrate to Single Page App #175

Closed ghost closed 1 year ago

ghost commented 1 year ago

This PR is a major refactor meant to convert this site to a single-page app with React components from a multi-page app with some React incorporated.

This PR also includes changes to move static assets to the public folder.

In addition to being a major refactor, this page will also fix the issue where, when navigating to the /classes page, clicking the "Classes" link in the navbar took users to /classes/classes.

Changes are live at https://ismandycoding.github.io/new-hsl/

mindblender commented 1 year ago

ran npm run dev locally and I'm seeing console errors that I don't see on the live site:

Warning: Invalid DOM propertyfor. Did you meanhtmlFor?

Warning: Invalid DOM propertyframeborder. Did you meanframeBorder?

Uncaught (in promise) DOMException: Failed to register a ServiceWorker for scope ('http://127.0.0.1:5173/') with script ('http://127.0.0.1:5173/src/scripts/sw.js'): The path of the provided scope ('/') is not under the max scope allowed ('/src/scripts/'). Adjust the scope, move the Service Worker script, or use the Service-Worker-Allowed HTTP header to allow the scope.

Uncaught (in promise) TypeError: Cannot set properties of null (setting 'innerHTML') at doors.js:15:28

ghost commented 1 year ago

Addressed PR comments and ready for re-review.