heavenshell / vim-jsdoc

Generate JSDoc to your JavaScript code.
BSD 3-Clause "New" or "Revised" License
452 stars 44 forks source link

Support ES6 class methods #41

Closed IonicaBizau closed 9 years ago

IonicaBizau commented 9 years ago
class Parser {

    constructor (app) {
       ...
    }

    // This should be able to generate a nice comment
    parse (cb) {
      ...
    }
}

Is this a known issue or it's something that needs to be improved?

heavenshell commented 9 years ago
let g:jsdoc_enable_es6=1
class Parser {

    constructor (app) {
       ...
    }

    // This should be able to generate a nice comment
    /**
     * parse
     *
     * @param {function} cb The callback function.
     * @return {undefined}
     */
    parse (cb) {
      ...
    }
}
IonicaBizau commented 9 years ago

Ohhh, thanks!! :dizzy:

I love so much this plugin! :smile:

IonicaBizau commented 8 years ago

@heavenshell This looks broken––I did enable es6 using let g:jsdoc_enable_es6=1.

Any ideas?

image

heavenshell commented 8 years ago

@IonicaBizau I can't reproduced it. image

Can you show me your vimrc(jsdoc.vim settings) and step to reploduce?

IonicaBizau commented 8 years ago

@heavenshell This is my .vimrc. Here are the jsdoc related options.

heavenshell commented 8 years ago

@IonicaBizau Copy your vimrc settings, move to parse (cb) line, exec :JsDoc and hit all enter. But still can't reploduce it.

image

IonicaBizau commented 8 years ago

@heavenshell Hmm, thanks. Will try to debug the problem. It does work on my desktop computer, but not on my laptop. I did NeoBundleUpdate and still no change...

heavenshell commented 8 years ago

@IonicaBizau Thx. What the difference between your laptop and desktop. vimrc, other Vim plugin or Vim version etc.

I did NeoBundleUpdate and still no change...

JSDoc.vim has no dependency to other plugin, but if conflicted, please let me know.

IonicaBizau commented 8 years ago

@heavenshell Finally I solved this problem. I couldn't find any difference between my desktop and laptop, but I refactored my .vimrc from scratch and the issue disappeared. Thanks once again for this amazing plugin! :sparkles:

heavenshell commented 8 years ago

@IonicaBizau Nice to hear that. Thx.