Param defaults as optional?

[codeinabox]

Using the ES6 code for handling defaults and :JsDoc with prompts enabled it generates the following

  /**
   * getChildren
   *
   * @param {int} id
   * @param {int} pageSize=10
   * @param {int} page=1
   * @returns {Promise}
   */
  getChildren(id, pageSize = 10, page = 1) {

However as per the JSDoc documentation, should those params with defaults be listed as optional? ie

  /**
   * getChildren
   *
   * @param {int} id
   * @param {int} [pageSize=10]
   * @param {int} [page=1]
   * @returns {Promise}
   */
  getChildren(id, pageSize = 10, page = 1) {

[heavenshell]

@codeinabox ah, thx for reporting issue.

I'll fix it later, stay tuned 😊

[heavenshell]

@codeinabox Could you try fix/default_params branch?

[codeinabox]

Still getting the same output

[heavenshell]

fmmm, strange.

• open ./test/test.js
• move cursor to function defaultParams(arg, arg1 = 'foo', arg2 = 100) {} line
• type :Jsdoc

/**
 * defaultParams
 *
 * @param {string} arg
 * @param {string} [arg1='foo']
 * @param {number} [arg2=100]
 * @returns {undefined}
 */

Could you show me your jsdoc.vim settings?

[codeinabox]

I tried that but get

/**
 * defaultParams
 *
 * @param {string} arg
 * @param {string} arg1='foo'
 * @param {string} arg2=100
 */
function defaultParams(arg, arg1 = 'foo', arg2 = 100) {}

Settings are

Plugin 'heavenshell/vim-jsdoc'
    " vim-jsdoc {{{
    let g:jsdoc_allow_input_prompt = 1
    let g:jsdoc_enable_es6 = 1
    " }}}

[heavenshell]

@codeinabox Thx. Did you try https://github.com/heavenshell/vim-jsdoc/tree/fix/default_params branch?

[codeinabox]

Yes. Went into .vim/bundle/vim-jsdoc and switched to that branch when I tried earlier.

[heavenshell]

@codeinabox Thx, I couldn't reproduced...

So, I add print debug statement. Update fix/default_params branch.

Run jsdoc and :messages. than, debug messages shows. Could you paste debug messages?

[codeinabox]

Nothing seems to come up when I invoke :messages

[heavenshell]

I think your plugin manager is something wrong. I don't know what plugin manager are you using.

Yes. Went into .vim/bundle/vim-jsdoc and switched to that branch when I tried earlier.

Is this right way to switch branch? I think you did not switch branch.

[heavenshell]

Merge to master.