heavyai / heavyai-charting

Dimensional charting built to work natively with crossfilter rendered using d3.js
https://heavyai.github.io/heavyai-charting/
Other
399 stars 73 forks source link

Reformat contour state #593

Closed johallar closed 2 years ago

johallar commented 2 years ago

⚠️ This is built on top of the polygons stuff, so I set the target branch to that for diff's sake. Will merge this after that one and rebase on master

This also includes popups in the contour demo and some small changes around that

Merge Checklist

:wrench: Issue(s) fixed:

:smoking: Smoke Test

:ship: Merge

johallar commented 2 years ago

Thanks for the thorough review, I think we could go pretty deep on validation, but for now if you pass an invalid spec its gonna break, and the structure of the spec passed from immerse is quite static so should minimize the risk here.

I made https://heavyai.atlassian.net/browse/FE-16036 so I won't forgot to follow up once we have some breathing room