heavyai / heavyai-charting

Dimensional charting built to work natively with crossfilter rendered using d3.js
https://heavyai.github.io/heavyai-charting/
Other
399 stars 73 forks source link

[FE-17341] Fix divide by 0 error, handle large bin_dim_meters param values #657

Closed johallar closed 1 year ago

johallar commented 1 year ago

Test Dashboard mapd/dashboard/9368?filterSet=-NjJkvetcVtlF9fRxlYw&tab=-NjJkverljUTOKmJnkPn

This raster has a large enough stride that bin dim meters min/max are quite large. Try setting this value throughout the whole range.

Very large values caused the original error, and were being forced into incorrect types for the TF by calcite. This forces them to be floats, and prevents our optimization constant from getting to 0.

Merge Checklist

:wrench: Issue(s) fixed:

:smoking: Smoke Test

:ship: Merge