In an ORDER BY... statement in omnisql, NULLS LAST needs to be suffixed to every ordering expression. For example, ... ORDER BY foo DESC NULLS LAST, bar DESC NULLS LAST. However, currently, crossfilter only adds NULLS LAST to the end of the final ordering expression.
This was causing errors where some charts were seeing incorrect rendering because the null data was coming up first. This commit fixes that to properly add NULLS LAST to every ordering expression.
Merge Checklist
:wrench: Issue(s) fixed:
[x] Fixes FE-8908
:smoking: Smoke Test
[ ] Works in chrome
[ ] Works in firefox
[ ] Works in safari
[ ] Works in ie edge
[ ] Works in ie 11
:ship: Merge
[ ] author crafted PR's title into release-worthy commit message.
In an
ORDER BY...statement in omnisql,NULLS LASTneeds to be suffixed to every ordering expression. For example,... ORDER BY foo DESC NULLS LAST, bar DESC NULLS LAST. However, currently, crossfilter only addsNULLS LASTto the end of the final ordering expression.This was causing errors where some charts were seeing incorrect rendering because the null data was coming up first. This commit fixes that to properly add
NULLS LASTto every ordering expression.Merge Checklist
:wrench: Issue(s) fixed:
:smoking: Smoke Test
:ship: Merge