heavyai / heavyai-crossfilter

JavaScript library for exploring large multivariate datasets in the browser.
Other
51 stars 20 forks source link

[FE-9285] Fix global filter toggle not always applying to queries #94

Closed jonvuri closed 5 years ago

jonvuri commented 5 years ago

In some cases, disabled filters weren't properly being applied within the writeQuery methods. This was because the disabled filter arrays were sparse - though their indexes matched properly when disabled is true for a filter, if they have empty elements at the end, the allFilters concat'ed array that writeQuery loops over won't match the allDisabledFilters concat'ed array.

This pads out the disabled arrays first to fix that issue without having to reconfigure the loops.