search

heavyai / heavyai.jl

Julia client for OmniSci GPU-accelerated SQL engine and analytics platform
https://omnisci.github.io/OmniSci.jl/latest/
Other
21 stars 9 forks source link

Comment out thrift code #58

Closed randyzwitch closed 5 years ago

randyzwitch commented 5 years ago

Remove thrift code for now, with eye on removing altogether and replacing with generated sql statement in julia

codecov[bot] commented 5 years ago

Codecov Report

Merging #58 into master will decrease coverage by 3.4%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #58     +/-   ##
========================================
- Coverage    71.2%   67.7%   -3.5%     
========================================
  Files           7       8      +1     
  Lines         806     795     -11     
========================================
- Hits          574     539     -35     
- Misses        232     256     +24
Impacted Files Coverage Δ
src/thrift_code/types.jl 54.6% <ø> (-0.4%) :arrow_down:
src/thrift_code/client.jl 68.8% <ø> (-1.4%) :arrow_down:
src/client.jl 84% <100%> (-1.4%) :arrow_down:
src/dataframe_show.jl 76.9% <0%> (-0.9%) :arrow_down:
src/constructors.jl
src/internal.jl 85.1% <0%> (ø)
src/OmniSci.jl 100% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42a40d4...3b25a90. Read the comment docs.