search

heavyai / heavyai.jl

Julia client for OmniSci GPU-accelerated SQL engine and analytics platform
https://omnisci.github.io/OmniSci.jl/latest/
Other
21 stars 9 forks source link

Remaining create_table, Decimal support #61

Closed randyzwitch closed 5 years ago

randyzwitch commented 5 years ago

Add Decimals package to provide support for arbitrary precision. Updated getsqlcoltype for DecFP and Decimals types

codecov[bot] commented 5 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.6%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #61     +/-   ##
======================================
+ Coverage    76.3%   77%   +0.6%     
======================================
  Files           8     8             
  Lines         774   780      +6     
======================================
+ Hits          591   601     +10     
+ Misses        183   179      -4
Impacted Files Coverage Δ
src/thrift_code/types.jl 62.4% <ø> (ø) :arrow_up:
src/OmniSci.jl 100% <ø> (ø) :arrow_up:
src/thrift_code/enums.jl 78.5% <ø> (ø) :arrow_up:
src/thrift_code/client.jl 75.7% <ø> (ø) :arrow_up:
src/constructors.jl 96.3% <100%> (+3.6%) :arrow_up:
src/client.jl 88.5% <100%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 358573e...23f77b7. Read the comment docs.

randyzwitch commented 5 years ago

Need to write conversion methods for DecFP and Decimals to support load_table_binary_columnar. load_table for Decimals/DecFP fall back to generic TStringValue methods, so just need to write tests