search

heavyai / heavyai.jl

Julia client for OmniSci GPU-accelerated SQL engine and analytics platform
https://omnisci.github.io/OmniSci.jl/latest/
Other
21 stars 9 forks source link

Set missing to text encoding dict #77

Closed randyzwitch closed 4 years ago

randyzwitch commented 4 years ago

Work towards #76

codecov[bot] commented 4 years ago

Codecov Report

Merging #77 into master will increase coverage by 64%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #77     +/-   ##
========================================
+ Coverage    23.8%   87.9%    +64%     
========================================
  Files          11       6      -5     
  Lines        2557     215   -2342     
========================================
- Hits          609     189    -420     
+ Misses       1948      26   -1922
Impacted Files Coverage Δ
src/constructors.jl 95.3% <ø> (ø) :arrow_up:
src/mapd/MapD.jl
src/mapd/mapd_types.jl
src/completion_hints/completion_hints_types.jl
...rialized_result_set/serialized_result_set_types.jl
src/common/common_types.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b2401b...4fbc50b. Read the comment docs.

randyzwitch commented 4 years ago

LGTM. Validated as part of a separate project; not writing a test since this is an arbitrary default which might change in the future