search

heavyai / pymapd

Python client for OmniSci GPU-accelerated SQL engine and analytics platform
https://pymapd.readthedocs.io/en/latest/
Apache License 2.0
111 stars 50 forks source link

Update pinning #353

Closed xmnlab closed 3 years ago

xmnlab commented 3 years ago

This PR updates the pinnings and updates CI.

xmnlab commented 3 years ago

this PR is ready for review. thanks!

jclay commented 3 years ago

Hi @xmnlab thanks for the PR. Are you able to allow maintainer edits or resolve the merge conflict? I have resolved the master conflict, just need to make sure we keep the RBC tests that were recently added. The git patch resolution tries to combine the pipelines in the Jenkinsfile. See my branch here for how I resolved it: https://github.com/omnisci/pymapd/blob/jclay/update-pinning/Jenkinsfile

xmnlab commented 3 years ago

@jclay thanks for reviewing that. I added your code there, thank you so much.

maybe this PR is a bit old .. I saw that the team was changing the code related to pinning, not sure if this PR still has some value. let me know if I can fix or improve anything here. thanks!

PS: I tried to allow maintainers edits the branch, but I didn't find the option, sorry :(

andrewseidl commented 3 years ago

@mapd-bot-os retest this please

xmnlab commented 3 years ago

for some reason, I am not seeing the CI here. is it just for me? if not, should I open a new PR?

jclay commented 3 years ago

@xmnlab we are troubleshooting an issue where the CI fails to run on forks of the repo.

xmnlab commented 3 years ago

is there anything I can do? if this PR is still important and if you want to, feel free to push that to a branch here.

xmnlab commented 3 years ago

PS: just to clarify, I don't mind waiting for the CI too :)

jclay commented 3 years ago

Closing this in favor of the new PR ^