search

heavyai / rbc

Remote Backend Compiler
https://rbc.readthedocs.io
BSD 3-Clause "New" or "Revised" License
29 stars 10 forks source link

Support strings #192

Open pearu opened 3 years ago

pearu commented 3 years ago

Perhaps already have string dictionary support by inputting key_for_string, but could make nicer ux around this

pearu commented 3 years ago

See Slack discussions for ideas:

  1. https://quansight.slack.com/archives/C01CAU0U1FH/p1605526178096400
pearu commented 3 years ago

Related PRs:

guilhermeleobas commented 3 years ago

Related PR:

guilhermeleobas commented 2 years ago

TextEncodingNone and TextEncodingDict types are supported.

pearu commented 2 years ago

Tests in rbc/tests/heavyai/test_text_encoding.py cover the cases where TextEncodingDict variables are passed around but we don't have tests for accessing the content of TextEncodingDict variables. In short, we should be able to define a UDF that translates a TextEncodingDict variable to TextEncodingNone return value, for instance. And vice-versa, checking if TextEncodingNone variable can be converted to TextEncodingDict return value (I imagine if the input string is not in the strings dictionary, the conversion should fail, or add a new item to the dict).

guilhermeleobas commented 1 year ago

PR #531 adds support for python strings