heavyai / rbc

Remote Backend Compiler
https://rbc.readthedocs.io
BSD 3-Clause "New" or "Revised" License
29 stars 10 forks source link

omniscidb should scan CUDA_PATH and /lib folders when looking for libdevice file #326

Open guilhermeleobas opened 3 years ago

guilhermeleobas commented 3 years ago

https://github.com/omnisci/omniscidb-internal/blob/ebd3a5f4bec2d5925fc844e01a932f2cdd2eec90/CudaMgr/CudaMgr.cpp#L404-L430

pearu commented 3 years ago

I think it is rather here: https://github.com/omnisci/omniscidb-internal/blob/ebd3a5f4bec2d5925fc844e01a932f2cdd2eec90/QueryEngine/NativeCodegen.cpp#L1367-L1380 where the scanning for libdevice location should be implemented.

guilhermeleobas commented 3 years ago

This might be a simple PR. One needs to do the following:

guilhermeleobas commented 3 years ago

Raising an exception might be a problem for other omnisci products (see image below). An alternative is to force the execution to the CPU when libdevice is unavaiable.

image