search

heavysixer / d4

A friendly reusable charts DSL for D3
MIT License
433 stars 46 forks source link

Grid offset #10

Closed Timopheym closed 9 years ago

Timopheym commented 10 years ago

If i create a grid for bar chat, the grid line goes throw the group. But i want to set it between the lines. How could it be done in a more elegant way?
screen shot 2014-05-12 at 8 20 56 pm

heavysixer commented 10 years ago

Hey @Timopheym what is the desired result? Do you want the grid line to be evenly spaced between the two groups?

Timopheym commented 10 years ago

Yes. For the bar charts, it would make sense to separate ticks from grid lines in order to provide a visual separation among the groups. screen shot 2014-05-12 at 8 30 51 pm

heavysixer commented 10 years ago

+1 I would investigate the grid feature because if you can do this with d3 natively you should be able to do it with d4 because it allows you to pass in the accessors already. So the next step would be to figure out how to do this with d3 out of the box.

Timopheym commented 10 years ago

We did the right choice, to rewrite all our d3 charts to d4.

Timopheym commented 10 years ago

For line chart it looks more strange screen shot 2014-05-14 at 3 50 03 pm

heavysixer commented 10 years ago

How would you control this in native d3?

Timopheym commented 10 years ago

What do you mean? Just make another position for grid.

heavysixer commented 10 years ago

Oh I meant how would you do this without d4 because that is how you should be able to do it with d4. Though it is curious that they don't line up with the dots out of the box. Is this something you can post as a fiddle or something?

heavysixer commented 9 years ago

Fixed in release ed84d7eaab1d1fce5b738ad5acb73301b7d24c3c