search

heavysixer / d4

A friendly reusable charts DSL for D3
MIT License
432 stars 46 forks source link

Id's conflicts #17

Closed Timopheym closed 10 years ago

Timopheym commented 10 years ago

Here D4 created svg element with chart id. https://github.com/heavysixer/d4/blob/master/src/base.js#L354 If you want to have several charts - you will get id conflicts. May be it would be better to remove id form there?

heavysixer commented 10 years ago

@Timopheym yes this is a good idea. Can you make this change and a test and send me a pull-request?

heavysixer commented 10 years ago

@Timopheym actually, why does this example not produce the same error? http://visible.io/charts/column/small-multiples.html

Do you have a fiddle document that you can show with this error?