search

heavysixer / d4

A friendly reusable charts DSL for D3
MIT License
432 stars 46 forks source link

Set axis min for column height using scaleId #37

Closed nsonnad closed 9 years ago

nsonnad commented 9 years ago

This is a fix for #36. The issue was that the height was using 0 as an axis min in useContiunuousSize. This PR adds xScaleId and yScaleId accessors for groupedColumnSeries and rectSeries, and this id is used to get the correct axis min. I have updated the multi-dimension in example in d4-www to draw this way, see this branch.

heavysixer commented 9 years ago

awesome let me review tonight, thanks for the hard work!

heavysixer commented 9 years ago

@nsonnad can you send me a pull request for the changes you made to d4-www? Thanks!

nsonnad commented 9 years ago

Here ya go: https://github.com/heavysixer/d4-www/pull/4