search

heb12 / heb12-electron

A simple Electron app for reading the Bible
https://heb12.github.io/desktop
GNU General Public License v3.0
10 stars 7 forks source link

Use electron-store module instead of localStorage #23

Closed MasterOfTheTiger closed 6 years ago

MasterOfTheTiger commented 6 years ago

I would like to switch things over to https://github.com/sindresorhus/electron-store instead of localStorage for reasons mentioned here: https://github.com/sindresorhus/electron-store/issues/17

AmazingMech2418 commented 6 years ago

We shouldn't use it for the online part.

MasterOfTheTiger commented 6 years ago

No we should not. You are right. However, I am planning a completely new online version built with PhP.

MasterOfTheTiger commented 6 years ago

This is done in commit 179bcdfb914bfc0c9d34a9452cd65eba70696871. All data previously used by people will be deleted when they run the new version. This is no big deal for three reasons:

  1. We are in 0.x still
  2. There is no information that is hard to reobtain
  3. We have no users to affect