heb12 / heb12-electron

A simple Electron app for reading the Bible
https://heb12.github.io/desktop
GNU General Public License v3.0
10 stars 7 forks source link

History Stops working with Single Chapter books #25

Closed MasterOfTheTiger closed 6 years ago

MasterOfTheTiger commented 6 years ago

Describe the bug Whenever the history menu is opened when a single chapter book is logged, the program sends the error:

Uncaught TypeError: Cannot read property 'verse' of undefined

To Reproduce Steps to reproduce the behavior:

  1. Go to a book with one chapter. e.g. 3 John
  2. Click on the history icon to open the history popup
  3. See that 3 John does not appear (nor does any chapter viewed afterwards)
  4. Open the console (Press CTRL+SHIFT+I)
  5. See error message

Expected behavior I expected the program to show all of the history. Instead it stopped short when it ran in to a single chapter book shown there.

Screenshots screenshot from 2018-08-12 20-20-54

Desktop (please complete the following information):

MasterOfTheTiger commented 6 years ago

I have narrowed down one part of the bug to openbibles. https://gitlab.com/MasterOfTheTiger/openbibles