search

heb12 / heb12mobile

Legacy Code for Heb12 Android App
https://heb12.github.io/heb12mobile/app/src/main/assets/index.html
GNU General Public License v3.0
8 stars 3 forks source link

Can't return translation string larger than 15MB #17

Closed petabyt closed 5 years ago

petabyt commented 5 years ago

Describe the bug When the app starts, it requests to get every translation in 1 string. This can be very big (30mb). For some reason, the app crashes and won't load. I get error: Uncaught Error: Java exception was raised during method invocation To Reproduce Steps to reproduce the behavior:

  1. Download more than 3 translations
  2. See error

Expected behavior The app should load fine

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

MasterOfTheTiger commented 5 years ago

This seems like we need to have it only request a translation when the user selects it, and replaced when a new one is selected. It can load it fairly quickly anyway right?

petabyt commented 5 years ago

Oh yeah. I have no idea why I didn't think of that. I'll try it later.

MasterOfTheTiger commented 5 years ago

Can you link to the commit in which this was fixed?

petabyt commented 5 years ago

@MasterOfTheTiger I'm pretty sure it is this: https://github.com/heb12/heb12-mobile/commit/bc6c2bd9992a58074fe84c8f90d6e65e268ecb97