search

heb12 / heb12mobile

Legacy Code for Heb12 Android App
https://heb12.github.io/heb12mobile/app/src/main/assets/index.html
GNU General Public License v3.0
8 stars 3 forks source link

Planned Additions/Fixes for 0.1.0 #3

Closed petabyt closed 5 years ago

petabyt commented 5 years ago
MasterOfTheTiger commented 5 years ago

Can you add instructions in the README for development instructions? Like setting it up in Android Studio.

petabyt commented 5 years ago

I was thinking about doing something like that in the wiki page. https://github.com/heb12/heb12-mobile/wiki

MasterOfTheTiger commented 5 years ago

@pufflegamerz Maybe, or maybe a development.md or something. We need something in a better place than the wiki, because it needs to be downloaded when someone clones the repo.

MasterOfTheTiger commented 5 years ago

Either way, it should be added.

petabyt commented 5 years ago

I think the app is ready to be released. I've fixed most of the major problems. Tell me if you find any bugs.

MasterOfTheTiger commented 5 years ago

Sorry. But I think we need more translations for more people to accept it. Don't you think? Maybe we should release the app as version 0.1.0 (following semantic versioning) now.

petabyt commented 5 years ago

I was hesitant about adding more translations, because it might make the app slower, and it already takes a while to load. What translations should I add? I don't see myself using more than 2.

MasterOfTheTiger commented 5 years ago

Okay. We need a better solution then. Can we load them into RAM only after they are selected?

petabyt commented 5 years ago

I just figured out a way to load the bible files only when a new translation is selected. I tried to do it before, and it didn't work. I guess I did something different and now it functional.

MasterOfTheTiger commented 5 years ago

Another few things which need to be done:

You should be able to reproduce all those issues. I found them in the 13th's version of the app. So you may have fixed some.

Here are some more things which should probably be done:

MasterOfTheTiger commented 5 years ago

Not sure you can do much about this, but it would be pretty useful to be able to use the up and down arrow keys on an Android hardware keyboard to move up and down on the Bible passage.

MasterOfTheTiger commented 5 years ago

Another thing we should do before the new version is released is the ability to easily compare versions in the popup. You can decide the best way to impliment it.

petabyt commented 5 years ago

Ok. I'll look into the issues. About the android keyboard part, are you talking about an external keyboard?

MasterOfTheTiger commented 5 years ago

Yes I am. It isn't a big deal, but I was trying to scroll down with the arrow keys and it didn't works. Kinda odd for a web based app when you think about it.

Another question is, how hard would this app be to translate? Do you use external Android strings?

MasterOfTheTiger commented 5 years ago

Another thing is, could you possibly be more descriptive in your commit messages? That's kinda important for both other contributors and for looking back at code later.

MasterOfTheTiger commented 5 years ago

Another bug:

MasterOfTheTiger commented 5 years ago

Ouch. The NET seems to be entirely broken. It says "undefined" where the Scripture should be.

petabyt commented 5 years ago

Press next, it should work.

petabyt commented 5 years ago

I attached a keyboard to my phone and the scrolling with arrow keys worked.

MasterOfTheTiger commented 5 years ago

Oh, I understand now. It kinda works like TAB by selecting all of the verse numbers. The NET still doesn't work, and the previous button should be fixed. It is entirely inconsistent.

petabyt commented 5 years ago

I fixed some of the issues. The NET should work now.

petabyt commented 5 years ago

I kinda want to make a dedicated website for Heb12 Mobile, because the one we have right now just looks a little plain.

MasterOfTheTiger commented 5 years ago

Okay. You can do that. Put it in a gh-pages branch

petabyt commented 5 years ago

I put it in the docs directory. https://heb12.ml/heb12-mobile/ Do you think it looks good? I will definitely change it a lot later on.

MasterOfTheTiger commented 5 years ago

Awesome! I like it.

By the way, how can I help with Heb12 Mobile? What do you need me to do?

MasterOfTheTiger commented 5 years ago

And how does the verse of the day code work?

petabyt commented 5 years ago

Thanks! The side menu definitely needs some touching up, and the online NET translation css needs some work. The verse of the day comes from the Bible Labs API. http://labs.bible.org/api/?passage=votd

MasterOfTheTiger commented 5 years ago

@pufflegamerz If I have a chance I will work on it. We need to do as much work as we can in the next week. Hopefully we can publish it on Google Play within a week (at least some kind of beta). Then later F-Droid as well.

petabyt commented 5 years ago

I'm pretty sure there is a $25 fee to get a developer account on Google Play. The Amazon App store is free though.

MasterOfTheTiger commented 5 years ago

Yeah. I know. I might see about paying it if I can.

I'll see about putting it in the Amazon app store. F-Driod is also free but can be cumbersome.

petabyt commented 5 years ago

You don't have to. I have an Amazon Developer account where I published a couple of apps a couple of years ago.

MasterOfTheTiger commented 5 years ago

@pufflegamerz. Okay. But to be honest, I would like to have access to it somehow. Because I am the owner of Heb12. Of course you are the lead (and only) developer of Heb12 Mobile, so I am fine with you publishing it. Once we agree on the release of 0.1.0 you can publish it.

petabyt commented 5 years ago

Could I make a folder in the heb12.github.up repository named Mobile so I can put the website in it? The code and website probably shouldn't be in the same repository.

MasterOfTheTiger commented 5 years ago

Yes. That is totally fine.

MasterOfTheTiger commented 5 years ago

@pufflegamerz Verse selection in NET is very broken.

petabyt commented 5 years ago

It works for me. What book and chapter is it?

On Saturday, March 9, 2019, MasterOfTheTiger notifications@github.com wrote:

@pufflegamerz https://github.com/pufflegamerz Verse selection in NET is very broken.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heb12/heb12-mobile/issues/3#issuecomment-471205078, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3qssM7Osdi5b5i44Xrc7aqCDvs1IXgks5vU_MlgaJpZM4aynbW .

petabyt commented 5 years ago

Oh. I see it. The highlighting won't work.I'll investigate.

On Saturday, March 9, 2019, Petabyte Studios brikbusters@gmail.com wrote:

It works for me. What book and chapter is it?

On Saturday, March 9, 2019, MasterOfTheTiger notifications@github.com wrote:

@pufflegamerz https://github.com/pufflegamerz Verse selection in NET is very broken.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heb12/heb12-mobile/issues/3#issuecomment-471205078, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3qssM7Osdi5b5i44Xrc7aqCDvs1IXgks5vU_MlgaJpZM4aynbW .

petabyt commented 5 years ago

The API sends the text in some wierd format: http://labs.bible.org/api/?passage=John%203&type=json&callback=myfunction

On Saturday, March 9, 2019, Petabyte Studios brikbusters@gmail.com wrote:

Oh. I see it. The highlighting won't work.I'll investigate.

On Saturday, March 9, 2019, Petabyte Studios brikbusters@gmail.com wrote:

It works for me. What book and chapter is it?

On Saturday, March 9, 2019, MasterOfTheTiger notifications@github.com wrote:

@pufflegamerz https://github.com/pufflegamerz Verse selection in NET is very broken.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heb12/heb12-mobile/issues/3#issuecomment-471205078, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3qssM7Osdi5b5i44Xrc7aqCDvs1IXgks5vU_MlgaJpZM4aynbW .

petabyt commented 5 years ago

http://labs.bible.org/api/?passage=John%203&type=json&callback=myfunction&&formatting=full

On Saturday, March 9, 2019, Petabyte Studios brikbusters@gmail.com wrote:

The API sends the text in some wierd format: http://labs.bible.org/ api/?passage=John%203&type=json&callback=myfunction

On Saturday, March 9, 2019, Petabyte Studios brikbusters@gmail.com wrote:

Oh. I see it. The highlighting won't work.I'll investigate.

On Saturday, March 9, 2019, Petabyte Studios brikbusters@gmail.com wrote:

It works for me. What book and chapter is it?

On Saturday, March 9, 2019, MasterOfTheTiger notifications@github.com wrote:

@pufflegamerz https://github.com/pufflegamerz Verse selection in NET is very broken.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heb12/heb12-mobile/issues/3#issuecomment-471205078, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3qssM7Osdi5b5i44Xrc7aqCDvs1IXgks5vU_MlgaJpZM4aynbW .

MasterOfTheTiger commented 5 years ago

@pufflegamerz In addition, normal verse selection doent seem to be working consistently.

petabyt commented 5 years ago

It should work in the latest apk.

petabyt commented 5 years ago

For some reason, I uploaded an older apk file. It should work now.

MasterOfTheTiger commented 5 years ago

The font size still does not work. It reads "NaN". I am able to change the Heb12 config file to a valid number to change this though.

Plus. Shouldn't the config file be in the Android assigned location for heb12? (Android/data/io.github.heb12.heb12mobile or something like that).that should fix the storage problem.

petabyt commented 5 years ago

Hmmm. It works good on my phone. What version of Android are you using?

On Sunday, March 10, 2019, MasterOfTheTiger notifications@github.com wrote:

The font size still does not work. It reads "NaN". I am able to change the Heb12 config file to a valid number to change this though.

Plus. Shouldn't the config file be in the Android assigned location for heb12? (Android/data/io.github.heb12.heb12mobile or something like that).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heb12/heb12-mobile/issues/3#issuecomment-471283661, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3qsmTdXTj8vAiZouZ1gPyef-iDaBHKks5vVPqkgaJpZM4aynbW .

MasterOfTheTiger commented 5 years ago

5.0. But shouldn't that be irrelevent? Try deleting the app and the configuration file and try again.

MasterOfTheTiger commented 5 years ago

By the way Android 4.x doesn't work. It installs, but the app gets stuck at the loading part.

petabyt commented 5 years ago

I'm pretty sure every version has a different webview version.

On Mon, Mar 11, 2019, 6:11 AM MasterOfTheTiger notifications@github.com wrote:

By the way Android 4.x doesn't work. It installs, but the app gets stuck at the loading part.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heb12/heb12-mobile/issues/3#issuecomment-471479554, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3qstI30iQmJ2izDKve4xaUo60xZUoLks5vVivYgaJpZM4aynbW .

petabyt commented 5 years ago

There might be a way to update it though.

On Mon, Mar 11, 2019, 3:23 PM Petabyte Studios brikbusters@gmail.com wrote:

I'm pretty sure every version has a different webciew version.

On Mon, Mar 11, 2019, 6:11 AM MasterOfTheTiger notifications@github.com wrote:

By the way Android 4.x doesn't work. It installs, but the app gets stuck at the loading part.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heb12/heb12-mobile/issues/3#issuecomment-471479554, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3qstI30iQmJ2izDKve4xaUo60xZUoLks5vVivYgaJpZM4aynbW .

MasterOfTheTiger commented 5 years ago

You need to make sure that it opens the last Bible translation used (if you haven't done that already).

petabyt commented 5 years ago

I've tried making that work for hours, but I was never able to fix it.