search

hebcal / dotcom

deprecated hebcal.com source code
https://github.com/hebcal/hebcal-web
21 stars 9 forks source link

Fix nikudot and dagesh in hebrew month names #10

Closed mjradwin closed 4 years ago

mjradwin commented 10 years ago

Dear Michael,

thanks for hebcal, It's very useful! I've noticed that the spelling of the nikudot and the dagesh in names of some months on www.hebcal.com and in the respective daily rss is incorrect (as far as I know, this has nothing to do with the *nix command, which outputs ktiv male):

בְּתִּשְׁרֵי should be בְּתִשְׁרֵי בְּכִּסְלֵו should be בְּכִסְלֵו בְּשְׁבָט should be בִּשְׁבָט בְּאַדָר should be בַּאֲדָר בְּאִיָיר should be בְּאִיָּר בְּתָּמוּז should be בְּתַמּוּז בְּאֱלוּל should be בֶּאֱלוּל

Best wishes, Andrey Rozenberg

yisraeldov commented 10 years ago

What are your sources for the spelling changes ?

I’m not a spelling expert but we should really have a source if we are going to make a change like this …

On Kislev 24, 5774 , at 1:32, Michael J. Radwin notifications@github.com wrote:

Dear Michael,

thanks for hebcal, It's very useful! I've noticed that the spelling of the nikudot and the dagesh in names of some months on www.hebcal.com and in the respective daily rss is incorrect (as far as I know, this has nothing to do with the *nix command, which outputs ktiv male):

בְּתִּשְׁרֵי should be בְּתִשְׁרֵי בְּכִּסְלֵו should be בְּכִסְלֵו בְּשְׁבָט should be בִּשְׁבָט בְּאַדָר should be בַּאֲדָר בְּאִיָיר should be בְּאִיָּר בְּתָּמוּז should be בְּתַמּוּז בְּאֱלוּל should be בֶּאֱלוּל

Best wishes, Andrey Rozenberg

— Reply to this email directly or view it on GitHub.

alephreish commented 10 years ago

Names of months follow the general rules of (Biblical) Hebrew (in this context: principally spirantization and vowel assimilation). The very forms can be checked here: http://search.freefind.com/find.html?id=6433772&pageid=r&mode=ALL&n=0&_charset_=UTF-8&query=%D7%91%D6%BC%D6%B0%D7%AA%D6%B4%D7%A9%D7%81%D6%B0%D7%A8%D6%B5%D7%99

alephreish commented 10 years ago

I've just noticed, that I in turn made a typo: nekudot :)

aperomsik commented 10 years ago

My son just started calling the converter from a function in a Google spreadsheet. I was all impressed until I saw the nikud.

alephreish commented 9 years ago

Any progress on this front?

alephreish commented 9 years ago

Great!

dsadinoff commented 4 years ago

This is not great. Iyyar is spelled כתב מלא in modern Hebrew. I strongly recommend reverting this for Iyyar.

mjradwin commented 4 years ago

So instead of בְּאִיָּר it should actually be בְּאִיָיר as it was originally?

mjradwin commented 4 years ago

To be clear, this is showing up on a Hebrew Date Converter page like this one

ח׳ בְּאִיָּר תש״פ

would be better instead as this?

ח׳ בְּאִיָיר תש״פ

dsadinoff commented 4 years ago

I think so. If Andrey insists that it's wrong then I would suggest removing the nikud entirely (maybe only for Iyyar) rather than show כתב חסר. It looks weird and wrong.

mjradwin commented 4 years ago

Deployed a couple of weeks ago.