hebcal / dotcom

deprecated hebcal.com source code
https://github.com/hebcal/hebcal-web
21 stars 9 forks source link

Candle Lighting offset in Shabbat API #13

Closed lukecarbis closed 9 years ago

lukecarbis commented 9 years ago

Currently there is a m parameter, to specify a minutes after sundown for Havdalah times.

However, there is no parameter for specifying minutes before sunset for Candle Lighting times.

While most of the world uses 18 minutes, here in Jerusalem we light the candles at 40 minutes before sunset.

My proposal is to retain the m parameter, for backward compatibility, but introduce two new parameters:

Here are some references on the topic: Judaism Stack Exchange question Chabad.org candle lighting times use 40 minutes for Jerusalem

lukecarbis commented 9 years ago

I just discovered that there is, in fact, a parameter (b) for the candle lighting offset, it's just not documented on the Shabbat Times Rest API page.

But I have tested and it works.

Feel free to close this ticket, or if you wanted to update the docs first, and then close it, that works too.

mjradwin commented 9 years ago

Updated the documentation to explicitly mention the b parameter. Thanks!