hebcal / dotcom

deprecated hebcal.com source code
https://github.com/hebcal/hebcal-web
21 stars 9 forks source link

Modern minor holidays and modern major holidays #23

Open sgladstone opened 7 years ago

sgladstone commented 7 years ago

I am trying to understand how various modern holidays are classified, and how to control what I get on my calendars.

In the current list of modern holidays, some I consider major (and want them shown) and others are minor, and I want the ability to not show them.

Specifically I would classify them as follows:

Currently in the HebCal APIs, there are already 2 parameters: min=on, mod=on. Ideas?

sgladstone commented 7 years ago

another parameter that I am not sure how it impacts these holidays is the "i=on" for the Israeli holiday schedule.

mjradwin commented 7 years ago

The Hebcal API already offers pretty fine-grained control. Couldn't your application simply specify mod=on and then filter out the list of holidays you don't want to show?

sgladstone commented 7 years ago

My application provides a configuration screen to admin users, that controls what parameters are sent to the HebCal API.

I was hoping to provide another config option, or better document how to use the existing ones. My application is an open source Drupal module at: https://www.drupal.org/sandbox/fountaintribe/2830659

mjradwin commented 7 years ago

The six holiday options on this page https://www.hebcal.com/home/195/jewish-calendar-rest-api

correspond to the groupings on this page:

https://www.hebcal.com/holidays/

You'll also find a type= parameter in this file:

https://github.com/hebcal/dotcom/blob/master/hebcal.com/dist/festival.xml

yisraeldov commented 7 years ago

Is there a such thing as a "major modern holiday"? I understood that major Holliday means, a real yom tov. On יום א׳, 27 בנוב 2016 at 03:29 Sarah Poger Gladstone < notifications@github.com> wrote:

another parameter that I am not sure how it impacts these holidays is the "i=on" for the Israeli holiday schedule.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hebcal/dotcom/issues/23#issuecomment-263096527, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIb61f_5xfTw3K53otibkPNQ-8pNQpZks5rCN0OgaJpZM4K9CRE .

sgladstone commented 7 years ago

In the Array of data that is returned from the API, there is a field indicating if a major holiday is also a yom tov ( ie the ones with dates in bold in the major holiday section at https://www.hebcal.com/holidays/)

Also, is there documentation or a source file on GitHub that would help me understand the full impact of using "i=on" for the Israeli setting? ie impact on holidays, torah readings, anything else impacted by "i=on"

sgladstone commented 7 years ago

My biased, informal definition of "major holiday" (modern or not) is a) Does the average Jewish person know of the holiday's existence, b) Does the average synagogue/Jewish community center (both outside and inside of Israel) have some event/activity to observe the holiday.

Yom HaAtzma'ut meets this criteria. Yom Yerushalayim does not.

(My logic is inherently flawed since there is no such thing as an average Jewish anything, everyone is unique)