search

hebcal / hebcal-es6

perpetual Jewish Calendar with holidays, Shabbat and holiday candle lighting and havdalah times, Torah readings, and more
https://hebcal.github.io/api/core/
GNU General Public License v2.0
98 stars 14 forks source link

No seaLevelSunrise() method on Zmanin #417

Closed YizYah closed 5 months ago

YizYah commented 5 months ago

The documentation refers to the method seaLevelSunrise() for the Zmanim object. But it does not appear to exist on the object.

This method would be quite useful in Israel, because it seems to me that the widely accepted calendar "Itim Levina" uses elevation for shkeya, but not for neitz.

Of course, there is a workaround to create two Zmanim instances and to make whatever calculations are necessary, but it would be nice to have just one.

Really, if I am correct about the way these times are being calculated in Israel, the ideal would be to be able to create an instance of a Zmanim with elevation used only for sunset but not for sunrise.

mjradwin commented 5 months ago

Fixed in 5.3.1

YizYah commented 5 months ago

Amazing turnaround @mjradwin thanks!