hebcal / hebcal-es6

perpetual Jewish Calendar with holidays, Shabbat and holiday candle lighting and havdalah times, Torah readings, and more
https://hebcal.github.io/api/core/
GNU General Public License v2.0
98 stars 14 forks source link

Refactor Holiday.getCategories() for readibility #439

Closed YizYah closed 3 months ago

YizYah commented 3 months ago

Replace case statement with if, remove… unneeded default/else, use desctructuring to get consts from hdesc.

Note: I'm purposely starting to contribute with a simple change.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud