search

hebcal / hebcal-es6

perpetual Jewish Calendar with holidays, Shabbat and holiday candle lighting and havdalah times, Torah readings, and more
https://hebcal.github.io/api/core/
GNU General Public License v2.0
98 stars 14 forks source link

Attempt to port tachanun from JS to TS #446

Closed mjradwin closed 3 months ago

mjradwin commented 3 months ago

Hi @YizYah, I'm trying a small experiment to mix TypeScript in with this repo and I'm having trouble getting the unit tests to work correctly. Do you have time to take a look?

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

YizYah commented 3 months ago

@mjradwin about to head out... let me have a look tomorrow, bli neder.

mjradwin commented 3 months ago

Thanks! Obviously no urgency here - this is the smallest experiment that I could think of so we can begin to do the JS => TS rewrite.

mjradwin commented 3 months ago

One idea is to explore rewriting all of the tests from Ava to Jest. This would be a bit tedious, but Jest seems to be more widely used than Ava, and therefore may have better support for projects mixing typescript and JS.

mjradwin commented 3 months ago

Scratch this. I've figured out how to make this work by rewriting unit tests from Ava to Jest. Closing this PR.

YizYah commented 3 months ago

For the record, I think it's the right choice. I was a real Ava enthusiast a few years ago, but everyone uses Jest today. That makes it smoother to work with AI or find answers to questions, and relevant code is better maintained (such as VS code plugins). We live in a winner-takes-all world LOL.